-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOBP-659] Add remote feature flag to the new payment section #5798
chore: [IOBP-659] Add remote feature flag to the new payment section #5798
Conversation
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… 'IOBP-659-remote-feature-flag-new-payment-section' of https://github.com/pagopa/io-app into IOBP-659-remote-feature-flag-new-payment-section
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5798 +/- ##
==========================================
+ Coverage 48.42% 49.71% +1.29%
==========================================
Files 1488 1630 +142
Lines 31617 32428 +811
Branches 7669 7842 +173
==========================================
+ Hits 15311 16123 +812
- Misses 16238 16242 +4
+ Partials 68 63 -5
... and 562 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR adds the remote feature flag to the new payment section. It will be visible only when the remote or local FF is enabled. (The local feature flag is considered only if the remote one is disabled)
List of changes proposed in this pull request
isNewPaymentSectionEnabledSelector
selector that takes into account remote configurationisNewWalletSectionEnabledSelector
with this new one but the previous one is still available in order to show the local feature flag.How to test
enabled
attribute from thenewPaymentSection
into thebackend.ts
file on the dev-server